Added versioning configuration for COS buckets in CSI driver #172
+112
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bhagyashreek8
requested changes
May 14, 2025
| if val, ok := secretMap["BucketVersioning"]; ok && val != "" { | ||
| enable := strings.ToLower(strings.TrimSpace(val)) | ||
| if enable != "true" && enable != "false" { | ||
| return nil, status.Error(codes.InvalidArgument, fmt.Sprintf("Invalid BucketVersioning value in secret: %s. Must be 'true' or 'false'", val)) |
There was a problem hiding this comment.
Please log secret name as well her.
status.Error(codes.InvalidArgument, fmt.Sprintf("Invalid BucketVersioning value in secret: %s. Value set %s. Must be 'true' or 'false'", secretName, val))
| fmt.Sprintf("Invalid BucketVersioning value in storage class: %s. Must be 'true' or 'false'", val)) | ||
| } | ||
| BucketVersioning = enable | ||
| klog.Infof("BucketVersioning set via storage class: %s", BucketVersioning) |
There was a problem hiding this comment.
klog.Infof("BucketVersioning value that will be set via storage class params: %s", BucketVersioning)
| @@ -48,6 +48,7 @@ func (cs *controllerServer) CreateVolume(_ context.Context, req *csi.CreateVolum | |||
| kpRootKeyCrn string | |||
| pvcName string | |||
| pvcNamespace string | |||
| BucketVersioning string | |||
| return nil, status.Error(codes.InvalidArgument, fmt.Sprintf("Invalid BucketVersioning value in secret: %s. Must be 'true' or 'false'", val)) | ||
| } | ||
| BucketVersioning = enable | ||
| klog.Infof("BucketVersioning set via secret: %s", BucketVersioning) |
There was a problem hiding this comment.
klog.Infof("BucketVersioning value that will be set via secret: %s", BucketVersioning)
| @@ -441,6 +479,7 @@ func parseCustomSecret(secret *v1.Secret) map[string]string { | |||
| iamEndpoint string | |||
| cosEndpoint string | |||
| locationConstraint string | |||
| BucketVersioning string | |||
| @@ -479,6 +518,10 @@ func parseCustomSecret(secret *v1.Secret) map[string]string { | |||
| locationConstraint = string(bytesVal) | |||
| } | |||
|
|
|||
| if bytesVal, ok := secret.Data["BucketVersioning"]; ok { | |||
There was a problem hiding this comment.
bucketVersioning -> small case in the start to comply with how other params are set in the secret.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for enabling versioning on COS buckets via the IBM COS CSI driver